On 25 April 2016 at 23:07, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Luke Diamand <luke@xxxxxxxxxxx> writes: > >> This patchset updates the git-p4 tests so that they work with >> either Python2 or Python3. >> >> Note that this does *not* fix git-p4 to work with Python3 - that's >> a much bigger challenge. > > We use Python outside p4 tests (e.g. remote-svn test), and the way > they invoke the interpreter is to say "$PYTHON_PATH" and avoid > saying "python" which picks whatever random version of Python > interpreter happens to be the first on $PATH. Shouldn't the tests > touched by this series be doing the same? Yes, they should. I'll update them accordingly. But the real reason for doing this is that at some point, git-p4 has to start working with python3, since python2 is going away (albeit not until 2020). Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html