On 25/04/16 22:50, Philip Oakley wrote: > From: "Jeff King" <peff@xxxxxxxx> >> On Mon, Apr 25, 2016 at 05:10:30PM -0400, Jeff King wrote: >> >>> It should be handled in git-compat-util.h, which is included by cache.h, >>> which is included by remote.c. >>> >>> There we have: >>> >>> #ifndef __GNUC__ >>> #ifndef __attribute__ >>> #define __attribute__(x) >>> #endif >>> #endif >>> >>> which should make it a noop on compilers which don't know about it. Is >>> VS (or another file) setting __GNUC__? >> >> Of course it helps if we spell the name right... Indeed! ;-) Not that it matters, but the above #define in git-compat-util.h is not the relevant definition - msvc will not see it. However, it does see the #define on line 12 of compat/msvc.h. :-D ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html