On Mon, Apr 25, 2016 at 10:34:27PM +0100, Philip Oakley wrote: > It's not the __attribute__ definition (a Gnu C ism), rather its the > __attribute variant, which has a definition in regex_internal.h, and is used > in the regex code. It's that one that's used in remote.c that I can't fathom > (i.e. how it worked in normally) > > regex_internal.h#L160-164 > #ifdef __GNUC__ > # define __attribute(arg) __attribute__ (arg) > #else > # define __attribute(arg) > #endif > > thus when the compilation get to remote.c#L1662 it fails to find that > definition. > > Should that line use the gnu extension name? Yeah, sorry, see my followup response. We don't use "__attribute" at all ourselves. The reference you found is in compat code that we pulled in (so it does its own thing entirely), and the one in remote.c is just a typo/think-o that happened to work on gcc, et al. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html