Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > >> larsxschneider@xxxxxxxxx writes: >> >>> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; >> >> [[ is a bashism, and doesn't bring anything here compared to the POSIX >> [ ... ], or "test" which is prefered in Git's source code. >> >> The ; or the newline is not needed either. > > Honestly, I didn't know that we were even trying to be pure POSIX, > avoid bashism or GNUism, or in general to follow our shell scripting > style in the scriptlet in the .travis.yml file. I'm not implying that we should absolutely avoid non-POSIX constructs, just that the conjuction "non-POSIX + not useful" made me prefer to remain POSIX. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html