On 24 Apr 2016, at 18:37, SZEDER Gábor <szeder@xxxxxxxxxx> wrote:
>
> Quoting Lars Schneider <larsxschneider@xxxxxxxxx>:
>
>> On 24 Apr 2016, at 13:50, SZEDER Gábor <szeder@xxxxxxxxxx> wrote:
>>
>>> Signed-off-by: SZEDER Gábor <szeder@xxxxxxxxxx>
>>> ---
>>>
>>> As far as I can tell after eyeballing the test script, this was the
>>> only case where the &&-chain was broken.
>>>
>>> t/t9824-git-p4-git-lfs.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
>>> index 0b664a377c45..64f8d18216d4 100755
>>> --- a/t/t9824-git-p4-git-lfs.sh
>>> +++ b/t/t9824-git-p4-git-lfs.sh
>>> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and
>>> store files in LFS based on compr
>>> # We only import HEAD here ("@all" is missing!)
>>> git p4 clone --destination="$git" //depot &&
>>>
>>> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ"
>>> + test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
>> Thanks! I believe I remember some script/flag to detect broken &&-chains.
>> Do I imagine that or can anyone point me to it?
>
> It was introduced in bb79af9d0970 (t/test-lib: introduce --chain-lint
> option, 2015-03-20) and is enabled by default. Unfortunately, it
> can't "see" inside subshells, that's why it couldn't detect this case.
That explains it. Thank you!
- Lars
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html