On 20/04/16 19:41, Junio C Hamano wrote: > Elia Pinto <gitter.spiros@xxxxxxxxx> writes: > >> Elia Pinto (3): >> git.txt: document the new GIT_TRACE_CURL environment variable >> imap-send.c: introduce the GIT_TRACE_CURL enviroment variable >> http.c: implements the GIT_TRACE_CURL environment variable > > I think 2 & 3 need to be swapped; otherwise 2 would refer to > yet-to-be-invented curl_trace() function, and break the build > without 3, no? > > Strictly speaking 1 should come at the end for the same reason, as > setting GIT_TRACE_CURL after seeing that commit would not give users > anything new. Yep, I was just about to send an email saying that the patches should be in the exact opposite order! (ie. 1->3 and 3->1) That is *if* you want to keep them as a series. I would squash them into one patch ... > Other than that, I didn't find anything blatantly wrong ;-). Will > nitpick individual patches later but I expect that it would be > sufficient to locally tweak while queuing without rerolling. I have one small issue ... ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html