On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote: > David Turner <dturner@xxxxxxxxxxxxxxxx> writes: > > > The local variable 'options' was shadowing a global of the same > > name. > > > > Signed-off-by: David Turner <dturner@xxxxxxxxxxxxxxxx> > > --- > > OK. In general, giving a longer and more descriptive name to the > global would be a direction to lead to more readable code, though. OK, will do that instead. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html