On Mon, Apr 18, 2016 at 5:01 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> A single patch evolves into a series. > > Power of code inspection to see bugs that are not reported, perhaps > ;-)? > > I wonder if we can come up with test cases to cover these potential > issues that are addressed in [1/2]? I think we can do a chmod a-w on the .git file and then updating that file fails. (renaming is fine, but putting the new, possibly different link to the git dir in there fails.) I do not quite know what we'd expect from a "git mv -k" on that. It is documented as "skip move/rename errors", so maybe we need to undo the rename to actually skip it once an error occurs? That said I think I know how to write a test for that, but I am unsure if patch 1 is a good idea. Thanks, Stefan > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html