On Thu, 5 Apr 2007, Dana How wrote: > On 4/5/07, Nicolas Pitre <nico@xxxxxxx> wrote: > > What is the purpose of this patch? > > > > The try_delta() function is called with all objects before any object is > > written to a pack to find out how to deltify objects upfront. > > I set no_write for 2 different reasons in the patchset. > (1) When the blob is too big (--blob-limit) and will never be written. > (2) When the blob has been written to a previous, finished pack. > > You're correct that this patch will never see condition (2). Given that I proposed another way for big blobs in my previous email, then (1) should not be needed either. > I think my repository statistics are a little unusual. > Perhaps I'm getting ahead of myself here, > but I also wanted to experiment with writing all blobs to one set > of packs, and all trees, commits, and tags to another set > (but probably just one small pack). > I would use no_write for that and it would matter here. Again you should simply _not_ add objects you don't want to the list instead of adding them and marking them as unwanted. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html