Hi, I tried to address all the issues and (among other things) I've added a new test case to t/t98 group (t9829-git-p4-jobs.sh). Unfortunately, Travis CI build now fails with "non-executable tests: t9829-git-p4-jobs.sh" (https://travis-ci.org/git/git/jobs/123555944) Can you please advise how to mark it as executable? Does it need to be added to some configuration file? Or am I interpreting the error message incorrectly? Regards, Jan On Sat, Apr 16, 2016 at 12:10 AM, Luke Diamand <luke@xxxxxxxxxxx> wrote: > On 15 April 2016 at 21:27, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Jan Durovec <jan.durovec@xxxxxxxxx> writes: >> >>> --- >> >> A few issues. Please: >> >> (1) Sign-off your work. >> >> (2) Try to find those who are familiar with the area and Cc them. >> >> "git shortlog -s -n --since=18.months --no-merges git-p4.py" >> may help. >> >> (3) Follow the style of existing commits when giving a title to >> your patch. >> >> "git shortlog --since=18.months --no-merges git-p4.py" may >> help you notice "git-p4: do this thing" is the common way to >> title "git p4" patches. >> >> (4) Justify why your change is a good thing in your log message. >> What you did, i.e. "list p4 jobs when making a commit", can be >> seen by the patch, but readers cannot guess why you thought it >> is a good idea to extract "job%d" out of the P4 commit and to >> record them in the resulting Git commit, unless you explain >> things like: >> >> - what goes wrong if you don't? >> - when would "job%d" appear in P4 commit? >> - is it sane to assume "job0", "job1",... appear consecutively? >> >> (5) Describe what your change does clearly. "Adding list" is not >> quite clear. Where in the "git commit message" are you adding >> the list, and why is that location in the message the most >> appropriate place to add it? > > Additionally, it would be very useful to add a test case (see t/t98*). > There are quite a few test cases for git-p4, and they make maintenance > a lot easier. > > Some documentation (Documentation/git-p4.txt) would also be useful. > > Thanks > Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html