On Fri, Apr 15, 2016 at 1:06 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >>> +diff.emptyLineHeuristic:: >> >> I was looking at the TODO here and thought about the name: >> It should not encode the `emptyLine` into the config option as >> it is only one of many heuristics. >> >> It should be something like `diff.heuristic=lastEmptyLine` >> The we could add firstEmptyLine, aggressiveUp, aggressiveDown, >> breakAtShortestLineLength or other styles as well later on. >> >> I do not quite understand the difference between diff.algorithm >> and the newly proposed heuristic as the heuristic is part of >> the algorithm? So I guess we'd need to have some documentation >> saying how these differ. (fundamental algorithm vs last minute >> style fixup?) > > I actually do not think these knobs should exist when the code is > mature enough to be shipped to the end users. > > Use "diff.compactionHeuristics = <uint>" as an opaque set of bits to > help the developers while they compare notes and reach consensus on > a single tweak that they can agree on being good enough, and then > remove that variable before the code hits 'next'. > > Thanks. I was under the impression that we would want a longer lived configuration until we had enough data to say whether it was helpful to make it default. I guess i had thought it would need to be longer lived since there may be cases where it's not optimal and being able to turn it off would be good? I'd rather keep it semi-human readable vs a uint since it would help keep me sane when looking at it in the interim. Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html