On Fri, Apr 15, 2016 at 10:31:39AM -0700, Junio C Hamano wrote: > Last time I checked, I think the accesses to attributes from the > convert.c thing was one of the things that are cumbersome to make > safe in multi-threaded world. Multi-threaded grep has the same problem. I think we started with a big lock on the attribute access. That works OK, as long as you hold the lock only for the lookup and not the actual filtering. We later moved to pre-loading the attributes in 9dd5245c104, because looking up attributes in order is much more efficient (because locality of paths lets us reuse work from the previous request). So I'm guessing the major work here will be to split the "look up smudge attributes" step from "do the smudge". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html