Re: [PATCH (resend)] gitweb: Fix bug in "blobdiff" view for split (e.g. file to symlink) patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> git_patchset_body needs patch generated with --full-index option to
> detect split patches,...
> ...
> This patch fixes this bug in git_blobdiff (in "blobdiff" view).
>
> Junio, you probably have missed this patch in the noise...

Probably.  Although I do remember seeing the patch, it was
unclear why --full-index is needed (and it still is unclear to
me).  Do you have a parser that expects/depends on full
40-hexdigit hash on the index line?

Not a complaint but a question -- I do not mind (actually prefer,
probably) if gitweb worked on full 40-hexdigit internally to
avoid possible ambiguity issues, although the output may need to
be truncated to save people from having to see unneeded precision.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]