On Wed, Apr 13, 2016 at 11:44 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.bauva@xxxxxxxxx> wrote: > >> +test_expect_success 'status does not verbose without --verbose' ' >> + git status >actual && >> + ! grep "^diff --git" actual >> +' > > But what is this test checking? status is also a consumer of the verbose whose initial value is set to -1. This makes it include verbose in status output. This bug was fixed by explicitly initializing verbose to 0 if -1. SZEDER pointed out a bug[1] which broke some tests in and then when I fixed it, you requested me to include tests even in this patch[2] which I found convincing enough. [1]: http://article.gmane.org/gmane.comp.version-control.git/289730 [2]: http://article.gmane.org/gmane.comp.version-control.git/289993 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html