Hi, On Thu, 5 Apr 2007, Geert Bosch wrote: > > On Apr 5, 2007, at 11:30, Johannes Schindelin wrote: > > I don't think this is correct. git_config_rename_section() _should_ return > > an error. > > > > > Otherwise, renaming a branch would abort, leaving the repository in an > > > inconsistent state. > > > > This should take the hint from --rename-section, and print a warning (or > > not). > > Looking at the code, I deduced that git_config_rename_section() > returns a positive count of sections renamed, 0 if no matching > section exists and negative for another error condition. Ah, yes. You are completely right! > The proposed patch makes the behavior of an absent config file the same > as the behavior of an empty one, which seems sane to me. There should be > no warning, as it is perfectly fine to have no config file. Could you > elaborate on why you believe my patch is not correct? I elaborate by taking my objections back. Fair enough? Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html