On Mon, Apr 11, 2016 at 12:04 PM, <miwilliams@xxxxxxxxxx> wrote: > From 7201fe08ede76e502211a781250c9a0b702a78b2 Mon Sep 17 00:00:00 2001 > From: Mike Williams <miwilliams@xxxxxxxxxx> > Date: Mon, 11 Apr 2016 14:18:39 -0400 > Subject: [PATCH 1/1] wt-status: Remove '!!' from > wt_status_collect_changed_cb > > The wt_status_collect_changed_cb function uses an extraneous double negation > (!!) How is an !! errornous? It serves the purpose to map an integer value(-1,0,1,2,3,4) to a boolean (0,1, or a real bit in a bit field). > when determining whether or not a submodule has new commits. > > Signed-off-by: Mike Williams <miwilliams@xxxxxxxxxx> > --- > wt-status.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/wt-status.c b/wt-status.c > index ef74864..b955179 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -431,7 +431,7 @@ static void wt_status_collect_changed_cb(struct > diff_queue_struct *q, > d->worktree_status = p->status; > d->dirty_submodule = p->two->dirty_submodule; > if (S_ISGITLINK(p->two->mode)) > - d->new_submodule_commits = !!hashcmp(p->one->sha1, > p->two->sha1); > + d->new_submodule_commits = hashcmp(p->one->sha1, > p->two->sha1); > } > } > > -- > 2.8.0 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html