Re: [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 5 Apr 2007, Shawn O. Pearce wrote:
> 
> For glibc we do try to set _FILE_OFFSET_BITS to 64

I repeat: that's _broken_.

It's in no way portable. It's a glibc horror. It should not be used.

It was a quick hack, but the real way to do it is to use "loff_t" and 
"llseek".

But there simply isn't any way to do mmap() or pread() portably outside 
the 32-bit area. So there are good reasons why we should just limit 
pack-files to 32-bits on 32-bit architectures.

So I think that Dana's approach is just fundamentally correct. Yeah, we 
should probably have a 64-bit index as a *possibility*, but it simply 
isn't a replacement for "keep packs under 2GB in size".

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]