On 11/04/16 05:20, Torsten Bögershausen wrote: > On 04/11/2016 12:59 AM, Ramsay Jones wrote: > The header mentions cygwin, but changes it for linux, BSD and Mac OS as well. > Is this intentional ? Yes. I only compile on 32/64-bit linux and 64-bit cygwin these days, so I only noticed the warnings (yes I wrote error, but it should be warning) on cygwin. Other systems may suffer the same warnings, of course. >> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> >> --- >> git-compat-util.h | 17 ----------------- >> index-helper.c | 4 ++-- >> read-cache.c | 2 +- >> 3 files changed, 3 insertions(+), 20 deletions(-) >> >> diff --git a/git-compat-util.h b/git-compat-util.h >> index 0e35c13..c90c8c6 100644 >> --- a/git-compat-util.h >> +++ b/git-compat-util.h >> @@ -1043,21 +1043,4 @@ struct tm *git_gmtime_r(const time_t *, struct tm *); >> #define getc_unlocked(fh) getc(fh) >> #endif >> -#ifdef __linux__ >> -#define UNIX_PATH_MAX 108 >> -#elif defined(__APPLE__) || defined(BSD) >> -#define UNIX_PATH_MAX 104 >> -#else > Can we use a #elif __CYGWIN__ here to fix the re-definition just for cygwi ? As I said in the cover letter, that is an option - but why bother with UNIX_PATH_MAX at all? ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html