On Sat, Apr 09, 2016 at 10:17:56PM +0200, Tom G. Christensen wrote: > On 09/04/16 19:39, Jeff King wrote: > > > [1/3]: config: lower-case first word of error strings > > [2/3]: git_config_set_multivar_in_file: all non-zero returns are errors > > [3/3]: git_config_set_multivar_in_file: handle "unset" errors > > > > I applied them to 2.8.1 and ran the testsuite again on Solaris 8/x86 and the > segfault is gone. Thanks for testing. By the way, I ran the whole test suite with "--tee -v" and grepped for "(null)", which does find this case on glibc systems. I didn't see any other interesting cases (there _are_ mentions of "(null)", but they are from our code, not glibc converting NULLs). Which I guess is just corroborating your testing, since you would have seen any bad cases as segfaults. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html