"Michael S. Tsirkin" <mst@xxxxxxxxxx> writes: > I have this in .git/config > > [trailer "r"] > key = Reviewed-by > command = "echo \"Michael S. Tsirkin <mst@xxxxxxxxxx\"" > [trailer "s"] > key = Signed-off-by > command = "echo \"Michael S. Tsirkin <mst@xxxxxxxxxx\"" > > whenever I run git interpret-trailers -t r I see these lines added: > > Reviewed-by: Michael S. Tsirkin <mst@xxxxxxxxxx > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx > Reviewed-by: Michael S. Tsirkin <mst@xxxxxxxxxx > > Why is Reviewed-by repeated? Bug or feature? The first two lines are added unconditionally: $ echo | git interpret-trailers Reviewed-by: Michael S. Tsirkin <mst@xxxxxxxxxx Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx The last line is added because you've asked for it with --trailer r. I don't think it's currently possible to get the behavior you seem to expect, ie. to define trailer tokens fully (key and value) in your config file but use them only on request. (BTW, I think you wanted a closing > at the end) -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html