Re: [PATCH] diff: run arguments through precompose_argv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 05 Apr 2016, at 21:15, Johannes Sixt <j6t@xxxxxxxx> wrote:
> 
> Am 05.04.2016 um 19:09 schrieb Junio C Hamano:
>>> Thanks-to: Torsten Bögershausen <tboegi@xxxxxx>
> 
> I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like:
> 
> Thanks-to: Torsten Bögershausen <tboegi@xxxxxx>
> 
> -- Hannes

Thanks for reviewing and catching the NFD encoding error.

I will send in a patch v2 with the correct NFC encoding.

Would you also like me to alter the commit message as mentioned by Junio?

I could rewrite the sentence:

“As a result, no diff is displayed when feeding such a file path to the
diff command.”

into simply saying:

“As a result, no diff is displayed.”

However, I don't read the original message as it would imply that only
file paths are affected by the precompose_argv call. 

Are there other suggestions on improving the commit message?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]