On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spiros@xxxxxxxxx> wrote: > 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunshine@xxxxxxxxxxxxxx>: >> In addition to review comments by others, why are the new curl_dump() >> and curl_trace() functions duplicated in both patches rather than >> factored out to a shared implementation? > > It's right. Do you think i can use some existing file or should I > create a new object file ? Peff or Junio would be more qualified to answer, but perhaps the shared implementation could go in http.c? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html