From: Santiago Torres <santiago@xxxxxxx>
The run_gpg_verify function has two variables size, and len. This may
come off as confusing when reading the code. We clarify which one
pertains to the length of the tag headers by renaming len to
payload_length.
Signed-off-by: Santiago Torres <santiago@xxxxxxx>
---
Note: this used to be part of the previous patch on v3. I moved the
renaming part to a single patch to simplify the review.
tag.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tag.c b/tag.c
index 81e86e6..f6443db 100644
--- a/tag.c
+++ b/tag.c
@@ -9,20 +9,21 @@ const char *tag_type = "tag";
static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
{
struct signature_check sigc;
- int len;
+ int payload_length;
int ret;
memset(&sigc, 0, sizeof(sigc));
- len = parse_signature(buf, size);
+ payload_length = parse_signature(buf, size);
- if (size == len) {
+ if (size == payload_length) {
if (flags & GPG_VERIFY_VERBOSE)
- write_in_full(1, buf, len);
+ write_in_full(1, buf, payload_length);
return error("no signature found");
}
- ret = check_signature(buf, len, buf + len, size - len, &sigc);
+ ret = check_signature(buf, payload_length, buf + payload_length,
+ size - payload_length, &sigc);
print_signature_buffer(&sigc, flags);
signature_check_clear(&sigc);
--
2.8.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html