On Mon, Apr 4, 2016 at 12:58 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Fri, Apr 1, 2016 at 6:27 AM, Mehul Jain <mehul.jain2029@xxxxxxxxx> wrote: >> In test_autostash() there's a line >> >> echo test_cmp_rev HEAD^ copy && >> >> Originally it should have been >> >> test_cmp_rev HEAD^ copy && >> >> but this raise following error while testing >> >> ./t5520-pull.sh: 684: eval: diff -u: not found > > This is caused by the custom IFS=',\t=' which is still in effect when > test_cmp_rev() is invoked. You need to restore IFS within the loop > itself. Thanks for pointing it out. I made a mistake by not considering the consequences of setting IFS=',\t='. I tried it out again and this time all tests passed perfectly. I should been more careful in the first place while playing with IFS, but instead of that, I kept on thinking that there is some other problem with the script which lead to me making foolish changes in the script like putting an echo before "test_cmp_rev ...". It was nice of you to take out some time and point it out :) Also now that I have sent v2[1] of this series, which goes in different direction as far as implementation of these tests are concerned. I think the script now is useless (but I learned a bit about shell while writing it). Thanks, Mehul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html