> > if (cmdmode == 'v')
> > - return for_each_tag_name(argv, verify_tag);
> > + return for_each_tag_name(argv, pgp_verify_tag,
> > + GPG_VERIFY_VERBOSE);
>
> but I think that is coupling too closely. What happens later when the
> public, multi-file pgp_verify_tag function changes its interface? Or we
> want to change our interface here, and it no longer matches
> pgp_verify_tag? The results ripple a lot further than they should.
>
> I think you probably want to keep a simple adapter callback in this
> file, like:
>
> int verify_tag(const char *name, const char *ref, const unsigned char *sha1)
> {
> return pgp_verify_tag(name, GPG_VERIFY_VERBOSE));
> }
Yes, agreed. I'll give this a go
Thanks!
-Santiago
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html