On Fri, Apr 1, 2016 at 3:30 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Subject: [PATCH] submodule--helper: do not borrow absolute_path() result for too long > > absolute_path() is designed to allow its callers to take a brief > peek of the result (typically, to be fed to functions like > strbuf_add() and relative_path() as a parameter) without having to > worry about freeing it, but the other side of the coin of that > memory model is that the caller shouldn't rely too much on the > result living forever--there may be a helper function the caller > subsequently calls that makes its own call to absolute_path(), > invalidating the earlier result. > > Use xstrdup() to make our own copy, and free(3) it when we are done. > While at it, remove an unnecessary sm_gitdir_rel variable that was > only used to as a parameter to call absolute_paht() and never used s/absolute_paht/absolute_path/ > again. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html