On Thu, Mar 31, 2016 at 5:04 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> submodule--helper clone: remove double path checking
I think Junio mentioned in v1 that calling this "path checking" is misleading.
> We make sure that the parent directory of path exists (or create it
> otherwise) and then do the same for path + "/.git".
>
> That is equivalent to just making sure that the parent directory of
> path + "/.git" exists (or create it otherwise).
This part of the commit message is nicely improved.
The patch itself looks fine.
> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
> ---
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> @@ -215,11 +215,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
> }
>
> /* Write a .git file in the submodule to redirect to the superproject. */
> - if (safe_create_leading_directories_const(path) < 0)
> - die(_("could not create directory '%s'"), path);
> -
> strbuf_addf(&sb, "%s/.git", path);
> -
> if (safe_create_leading_directories_const(sb.buf) < 0)
> die(_("could not create leading directories of '%s'"), sb.buf);
> submodule_dot_git = fopen(sb.buf, "w");
> --
> 2.5.0.264.g39f00fe
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html