v3:
Thanks Eric, Jeff, Junio for discussion!
* use git_config_get_value instead of git_config_get_string in patch 1
* Improve commit message to explain why strbuf_list_free frees more memory
(hence is the right thing to do)
* the bundle code doesn't have a dedicated return variable,
but the error path always returns -1
* removed a duplicate of
+ if (!bundle_to_stdout)
+ close(bundle_fd);
in the bundle patch.
* This applies on v2.8.0.
v2:
Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here
is a v2.
* drop the overallocation patches (1&2)
* use git_config_get_string instead of its _const equivalent, such that
we don't need a cast when freeing in git_config_get_notes_strategy
* Use strbuf_list_free instead of cooking our own.
* have a dedicated error exit path in bundle.c, create_bundle
v1:
One of my first patches to Git were cleanup patches, and I fell back
to my old pattern here, while thinking on how to write better commit
messages for the submodule bugfixes I currently have in flight.
Just some one liners to not leak memory or file descriptors.
They are bundled as a series, but no patch relies on any predessor.
This applies on v2.8.0.
Thanks,
Stefan
Stefan Beller (4):
notes: don't leak memory in git_config_get_notes_strategy
abbrev_sha1_in_line: don't leak memory
bundle: don't leak an fd in case of early return
credential-cache, send_request: close fd when done
builtin/notes.c | 2 +-
bundle.c | 17 ++++++++++++-----
credential-cache.c | 1 +
wt-status.c | 4 +---
4 files changed, 15 insertions(+), 9 deletions(-)
--
2.5.0.264.g4004fdc.dirty
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html