2016-03-29 1:58 GMT+08:00 Junio C Hamano <gitster@xxxxxxxxx>: > Hui Yiqun <huiyiqun@xxxxxxxxx> writes: > >> According to strbuf.h, strbuf_detach is the sole supported method >> to unwrap a memory buffer from its strbuf shell. >> ... >> diff --git a/path.c b/path.c >> index 969b494..9801617 100644 >> --- a/path.c >> +++ b/path.c >> @@ -625,6 +625,7 @@ const char *enter_repo(const char *path, int strict) >> { >> static struct strbuf validated_path = STRBUF_INIT; >> static struct strbuf used_path = STRBUF_INIT; >> ... >> +return_null: >> + free(dbuf); >> + strbuf_release(&used_path); >> + strbuf_release(&validated_path); >> return NULL; >> } > > I see these strbuf's are "static" storage class, so that they do not > have to get freed. I see, thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html