2016-03-26 1:59 GMT+08:00 Jeff King <peff@xxxxxxxx>: > On Fri, Mar 25, 2016 at 10:21:48PM +0800, 惠轶群 wrote: > >> > There are some minor English problems here (and elsewhere). E.g., you >> > probably want "So we just issue a warning and leave it to the user to >> > solve.". >> >> Sorry for my English. > > Thanks. And sorry if that sounded too harsh. I know that working in a > non-native language is tough. Usually in a review I'll try to provide > specific English fixes, but in this case, I think a lot of these > messages are still in flux, so I I didn't want to waste either of our > time going over specifics if the content is just going to change later. > >> > These ones leak, too. >> >> I will deal with it. >> >> I find there are some similar leakage in this file. I'll fix them in >> another patch. > > Great, thanks. After read the source code of strbuf more carefully, I get the conclusion that if a strbuf is initialized with STRBUF_INIT but is not used, there is no need to release it. Is it true? > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html