On Fri, Mar 25, 2016 at 10:34 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > That works too, simplifying the overall implementation, and > eliminating the need for the introductory patch which moves > 'test_set_editor' into each test. Wouldn't it be cleaner if the introductory patch contain: 1. using write_script() 2. grep the output to a file 3. test for no of lines=1 in required tests ? Then the patch 3/3 >> And if you insist on doing the line counting in the editor script, then >> why redirecting grep's output and 'wc -l' separately, why not 'grep -c'? > > Ugh, I utterly forgot about -c. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html