On Fri, Mar 25, 2016 at 10:01 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> The other reason you gave below is also convincing: By having it in the prefix, >> the C code is more likely correct and future proof. >> >> On rewriting the whole submodule command in C (probably >> reiterating): It is not my endgoal to rewrite every submodule >> related part in C. It would be nice if it would happen eventually, >> but for now I only rewrite parts that I need in C. > > Well, what you personally would want to do yourself is irrelevant. > Doing submodule--helper in such a way that it is sufficient in a > half-way conversion but cannot be reused in future full rewrite is > something we would want to avoid, whether you would be doing the > full rewrite in the future. In fact, if you are not inclined to do > so yourself, that is one more reason to make sure that the C pieces > in submodule--helper are reusable (i.e. your "correct and future > proof" above); otherwise you'd be making it _more_ difficult for > other people who would want to pick it up where you left. Exactly, sorry for not writing my chain of thoughts down completely. To make them reusable, I'd assume we want them to be easy to understand, and by using a well known way in git it is easier to understand. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html