On Fri, Mar 25, 2016 at 4:44 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Fri, Mar 25, 2016 at 4:31 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>> for i in --autostash --no-autostash
>> do
>> test_expect_success "pull $i (without --rebase) is illegal" "
>> test_must_fail git pull $i . copy 2>actual &&
>> test_i18ngrep 'only valid with --rebase' actual
>> "
>> done
>>
>> Take special note of how use of double (") and single (') quotes
>> differ in this case from other tests since $i needs to be interpolated
>> into the test body.
>
> That's not accurate. Since $i will be visible when the test body is
> actually evaluated, it will work correctly even with the body
> single-quoted as usual (like all other tests), so swapping the quotes
> around like this is unnecessary (and Junio would prefer[1] they not be
> swapped).
Junio pointed out to me privately that I forgot to mention explicitly
that you would need to use double quotes for the test title to ensure
that $i is interpolated, but the test body can continue using single
quotes, as explained above.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html