2016-03-25 18:00 GMT+08:00 Jeff King <peff@xxxxxxxx>:
> On Wed, Mar 23, 2016 at 06:13:23PM +0800, Hui Yiqun wrote:
>
>> move .git-credential-cache/socket to xdg_runtime_dir("credential-cache.sock")
>
> Motivation?
I will improve my commit message.
>
>> diff --git a/credential-cache.c b/credential-cache.c
>> index f4afdc6..40d838b 100644
>> --- a/credential-cache.c
>> +++ b/credential-cache.c
>> @@ -105,7 +105,7 @@ int main(int argc, const char **argv)
>> op = argv[0];
>>
>> if (!socket_path)
>> - socket_path = expand_user_path("~/.git-credential-cache/socket");
>> + socket_path = xdg_runtime_dir("credential-cache.sock");
>> if (!socket_path)
>> die("unable to find a suitable socket path; use --socket");
>
> We do our own mkdir and chmod in credential-cache; this should be
> redundant with what xdg_runtime_dir() does, and can be removed, right?
But user may specify another path via --socket <path>, this path may have
wrong permission. I'm considering how to handle this situation.
>
> -Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html