On Thu, Mar 24, 2016 at 12:41 PM, Motroni Igor <motroniii@xxxxxxxxx> wrote:
> From: Pontifik <motroniii@xxxxxxxxx>
Here is a good place to put reasoning for why this is a good idea.
I see you have a long subject, so maybe we can shorten the first line
(down to less than ~ 80 characters) and put the longer explanation
here.
How about:
bisect: use unsigned for flag field
The flags are usually used as a unsigned variable, because it makes
bit operations easier to follow.
>
> Signed-off-by: Pontifik <motroniii@xxxxxxxxx>
>From Documentation/SubmittingPatches:
> Also notice that a real name is used in the Signed-off-by: line. Please
> don't hide your real name.
> ---
> bisect.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bisect.h b/bisect.h
> index acd12ef..a979a7f 100644
> --- a/bisect.h
> +++ b/bisect.h
> @@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
>
> struct rev_list_info {
> struct rev_info *revs;
> - int flags;
> + unsigned int flags;
You can also drop the int here and make it just
unsigned.
> int show_timestamp;
> int hdr_termination;
> const char *header_prefix;
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html