Re: [PATCH v7 09/33] refs: reduce the visibility of do_for_each_ref()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-03-24 at 08:07 +0100, Michael Haggerty wrote:
> > +/*
> > + * The common backend for the for_each_*ref* functions
> > + */
> > +static int do_for_each_ref(const char *submodule, const char
> > *base,
> > +		    each_ref_fn fn, int trim, int flags,
> > +		    void *cb_data)
> 
> The two lines above are indented incorrectly.

Fixed, thanks.

> > -
> > -int do_for_each_ref(const char *submodule, const char *base,
> > -		    each_ref_fn fn, int trim, int flags,
> > -		    void *cb_data)
> > -{
> > -	return the_refs_backend->do_for_each_ref(submodule, base,
> > fn, trim,
> > -						 flags, cb_data);
> > -}
> 
> Nit: in the previous patch, please put the function where you want it
> so
> that you don't have to move it in this patch.
> 
> > [...]
> 
> Michael

Ok.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]