Pranit Bauva <pranit.bauva@xxxxxxxxx> writes:
> On Wed, Mar 23, 2016 at 5:27 PM, Johannes Schindelin
> <Johannes.Schindelin@xxxxxx> wrote:
>> Hi Pranit,
>>
>> On Wed, 23 Mar 2016, Pranit Bauva wrote:
>>
>>> Convert the code literally without changing its design even though it
>>> seems that it is obscure as to the use of comparing revision to different
>>> bisect arguments which seems like a problem in shell because of the way
>>> function arguments are handled.
Are you talking about the need to do one_of("help", "start", ...)?
I do not see how that is "problem in shell" or "they way function
arguments are handled".
git bisect bad
git bisect good
are the ways how you mark the current commit as bad or good, and
recent change that introduced the "term" thingy allows you to
replace these "bad" and "good" with your own words, but
git bisect start
git bisect help
etc. have their own meaning, so you cannot say "I call bad state
'start' and good state 'help'" without confusing yourself. You'd
never be able to start or get help if you did so, and that does not
have anything to do with "shell" or "function argument" which are
implementation detail.
You cannot fundamentally allow replacing bad/good with these
blacklisted words unless you are going to adopt different command
line syntax (e.g. instead of accepting "git bisect $bad" with a word
chosen by the end user, use "git bisect mark $bad", and $bad can be
any word including "start", "visualize", etc.).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html