Re: [PATCH v6 7/7] git: submodule honor -c credential.* from command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 22, 2016 at 11:56:28AM -0700, Jonathan Nieder wrote:

> This is failing for me when I use "git submodule add" with a remote
> helper I whitelisted with GIT_ALLOW_PROTOCOL, with current "next":
> 
>  $ bin-wrappers/git submodule add persistent-https://kernel.googlesource.com/pub/scm/git/git sm
>  Cloning into 'sm'...
>  error: bogus format in GIT_CONFIG_PARAMETERS
>  fatal: unable to parse command-line config
>  fatal: clone of 'persistent-https://kernel.googlesource.com/pub/scm/git/git' into submodule path 'sm' failed
> 
> sq_dequote_to_argv doesn't like the space at the beginning of
> $GIT_CONFIG_PARAMETERS.  Reverting 14111fc4 fixes it.  Known
> problem?

It's known that the parsing end is excessively picky, but not this
particular bug. I found the problem; I'll have a patch out in a few
minute after I write a test.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]