On Fri, Mar 18, 2016 at 2:33 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> * Diff to v2 in t3404: >> test_expect_success 'rebase --exec works without -i ' ' >> git reset --hard execute && >> rm -rf exec_output && >> - git rebase --exec "echo a line >>exec_output" HEAD~2 2>actual && >> + EDITOR="echo >invoked_editor" git rebase --exec "echo a line >>exec_output" HEAD~2 2>actual && > > Hmph. If you add "-i" to the command line, do you see the > 'invoked_editor' file created? just tested that by adding EDITOR="echo >invoked_editor" git rebase -i ... test_path_is_file invoked_editor and it works. I have a patch here with s/EDITOR/EDITOR/, which I can send out...... and your follow up email came in, so I stop bothering about this patch until further reviews, ok? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html