On Thu, Mar 17, 2016 at 10:36:16PM -0700, Linus Torvalds wrote: > On Thu, Mar 17, 2016 at 10:08 PM, Jeff King <peff@xxxxxxxx> wrote: > > > > Hmm. Isn't "expand tabs" orthogonal to the rest of the pretty format? > > That is, couldn't one want "--pretty=fuller, but with tabs expanded"? > > Yeah, you are right, one easily could. And in fact I end up doing > "fuller" myself occasionally, because I check peoples commit > timestamps (some people have a nasty habit of rebasing when they > shouldn't). > > So it's not just the medium format that would want detab by default, > it's "full" and "fuller" too (but probably not "raw": that indents the > message too, but the only real reason to use "raw" is for scripting). > > So it would probably be better to make it a separate flag, and not tie > it to a particular log format (and just make the log format set the > default). Yeah, I agree with all of that. I didn't want to force anybody to have to think too hard about corner cases they don't care about (again, as long as we don't paint ourselves into a corner) but I tend to think that it makes sense to apply it consistently to all of the stock human-readable formats (short, medium, full, fuller), but not to "raw" or "email", and probably not to user-formats. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html