On Fri, Mar 18, 2016 at 6:49 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Thanks for these 5 patches, two of which need to be discarded ;-). > I think you can pick either one of 1/2, pick the one that says > "non-NULL" (as opposed to "something") in the log message for 2/2. Sorry, I did "git send-email ... 00*" and it picked up *.patch~ as well. non-NULL is the non-backup version. > Durham, does it fix your issues if you apply the 1/2 and 2/2 (but > not 3/2) on top of 2.8-rc? > > Duy, how comfortable are you with the idea of including this two in > 2.8 final? We have long passed the final -rc, and while it is > probably OK to prolong the cycle and do another -rc, we cannot keep > going like "oops, there is another thing discovered by somebody new" > forever. The fix is well understood. I did feel unsure about that "continue;" when I first wrote it and should have given it more thought. No other "unsure" feelings, so we're probably good from now on. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html