On Wed, Mar 16, 2016 at 8:47 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Wed, Mar 16, 2016 at 9:27 PM, Alexander Kuleshov > <kuleshovmail@xxxxxxxxx> wrote: >> We stripping extension in the list_commands_in_dir() to get >> commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION >> is defined to not spend time for unnecessary strip_suffix() call in >> this case. > > Unless the time saving is significant, I'm against this change. It > makes it harder to spot compile bugs in #ifdef'd code that's only > active on Windows (imagine somebody renames "ent" or change its type). > If you can do something like strip_extension() in git.c, it's better. > Or maybe just refactor that function a bit and share it with help.c Yes, agree. Will think about this. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html