On Tue, Mar 15, 2016 at 2:43 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Duy Nguyen <pclouds@xxxxxxxxx> writes:
>
>> On Sat, Mar 12, 2016 at 5:46 PM, Paul Tan <pyokagan@xxxxxxxxx> wrote:
>>> So, we have around a 1.4x-1.8x speedup for Linux users, and a 1.7x-13x speedup
>>> for Windows users. The annoying long delay before the interactive editor is
>>> launched on Windows is gotten rid of, which I'm very happy about :-)
>>
>> Nice numbers :-) Sorry I can't look at your patches yet. Just a very
>> minor comment from diffstat..
>>
>>> rebase-am.c | 110 +++++++++++
>>> rebase-am.h | 22 +++
>>> rebase-common.c | 220 ++++++++++++++++++++++
>>> rebase-common.h | 48 +++++
>>> rebase-interactive.c | 375 +++++++++++++++++++++++++++++++++++++
>>> rebase-interactive.h | 33 ++++
>>> rebase-merge.c | 256 +++++++++++++++++++++++++
>>> rebase-merge.h | 28 +++
>>> rebase-todo.c | 251 +++++++++++++++++++++++++
>>> rebase-todo.h | 55 ++++++
>>
>> topdir is already very crowded. Maybe you could move all these files
>> to "rebase" subdir.
>
> I think that makes sense. I do not expect people depending on being
> able to say "git rebase--am" and have it do something useful, so
> they won't belong to builtin/, but rebase/{am,common,...}.[ch] makes
> sense.
Sure, I'll do that.
Regards,
Paul
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html