Re: [PATCH] clone tests: rename t57* => t56*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 15, 2016 at 03:00:09PM -0700, Stefan Beller wrote:

> Talking about ordering, I have two use cases
> 
> 1) Before sending out patches: "git rebase -i -x make -x 'make test' <anchor>"
>   to catch myself for doing stupid things.
> 
> 2) When developing new code, I alternate between running an indivdual test
>   "cd t && GIT_TRACE=1 ./t7400... -d -i -x -v " and running prove for all tests
>   to have a good check if there are other niches I missed.

Yep, that is roughly my workflow, too (with the occasional "make test &&
make install" thrown in). :)

> So I do not really have strong preference for the right order, I even
> thought about omitting the paragraph from the commit message and
> wanted to put it into the notes below, but then I figured I want to
> record it as I was frustrated about the commit messages from 2006 as
> they don't answer simple questions like "Why did you use a different
> second digit?", so I figured if anyone digs up my commit eventually I
> want to record as much of my current reasoning even if it is minor to
> help a future developer?

I agree it is worth mentioning that you considered the order. I think
what you wrote was fine, though I probably would have said something
like:

  Moving t57* to higher digits in t56* preserves the existing ordering.
  That may or may not matter to anyone, but it does not hurt to keep it.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]