On Tue, Mar 15, 2016 at 5:01 PM, SZEDER Gábor <szeder@xxxxxxxxxx> wrote:
> You made 'commit.verbose' a boolean, so either verbose or not, ...
> ... but note these context lines telling us that --verbose can be
> specified not just once but twice (and who knows what the future may
> bring). This raises some not entirely rhetorical questions:
>
> - What does 'git config commit.verbose true && git commit --verbose'
> do?
This is a nice thought which didn't strike me!
As Eric Sunshine mentioned ($gmane.org/288811), it would react
according to the multiple verbosity level and since its not currently
defined in `commit` it will react as it is reacting when verbosity
level is 1.
If let's say we incorporate this behavior now, it can lead to
confusion for the user (not developer) as to whether `commit` supports
multiple verbosity.
> - Should 'commit.verbose' only care about the convenience of those
> who always prever '--verbose', or about those who like '-v -v',
> too?
>
> - If the latter, i.e. 'commit.verbose' should cater for '-v -v' as
> well, then what should 'git config commit.verbose "<verbose level
> two>" && git commit --verbose' do?
If I was the user, I would use multiple levels of verbosity only where
I would feel that there is some problem happening with the commit that
is in progress. Having an "awkward" commit isn't usual and definitely
not every time. Though if in future it is required, We can add edit
the line namely :
if(!strcmp(k, "commit.verbose")) {
- verbose = git_config_bool(k, v);
+ verbose = git_config_int(k, v);
return 0;
}
Additionally we will have to define scenarios and mention them in the
documentation as to how `commit` will react as this cannot be known by
intuition. This would complicate things for the user who is reading
the man pages.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html