On Mon, Mar 14, 2016 at 5:21 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: >> +test_expect_success 'status ignores commit.verbose=true' ' >> + git status >actual && > > This is missing the important "-c commit.verbose=false". Without it, > you're not really testing anything interesting. > > (It was missing in the "something like this" example test I typed > directly in the email of my last review[1], which I suppose is a good > lesson that "something like this" is not meant as "final" or "trust > this".) That wasn't an intentional omission on my part, by the way -- I wasn't trying to mislead you -- it was just an example I typed on-the-fly without thinking too hard about it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html