On Mon, Mar 07, 2016 at 04:19:31PM +0100, SZEDER Gábor wrote: > >Even though I think the original description did not mean to include > >the fetch refspecs when it talked about configuration taking effect, > >I think what this change wants to do probably makes sense. > > Well, currently one would have to clone, set additional fetch refspecs, > fetch again and repack. Using 'git clone -c <refspecs>' would do it in > a single step, requiring fewer commands, less time, less data transfer > and less disk space, which fits the justification of v1.7.7-rc0~90^2 > perfectly. Yeah, I think your change very much fits the spirit of what the original commit was trying for. > >My knee-jerk reaction is to change the last paragraph of your log > >message to read more like > > > > Always read the fetch refspecs from the newly created config > > file, and use that for the initial fetching. > > > >and do so even when running with "--single-branch". > > Ok, will change the '--single-branch' codepath as well. > > But before doing so, to avoid a possible misunderstanding on my part: > I'm not sure how literally you meant that "from the newly created > config file" part, because it ignores refspecs specified via any > other means, e.g. 'git -c <fetch-refspec> clone'. I think the > initial fetch should be no different from "regular" fetches, and > should respect all configured fetch refspecs regardless where they > come from. IMHO, we should stick to the conceptual model that "git clone" is: git init git config ... ;# set up remote, etc git fetch git checkout ;# obviously not for --bare The implementation has to diverge from that to do certain optimizations, but absent any good reason not to, I think we should aim for behaving "as if" those commands were run. It certainly may produce surprising behavior at times, but at least it is a conceptually simple mental model. I do admit, though I haven't thought hard enough to know whether there are any terrible gotchas there. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html