Mehul Jain <mehul.jain2029@xxxxxxxxx> writes: > On Thu, Mar 3, 2016 at 10:54 PM, Matthieu Moy > <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >> Mehul Jain <mehul.jain2029@xxxxxxxxx> writes: >>> + else { >>> + /* If --[no-]autostash option is called without --rebase */ >>> + if (opt_autostash == 0) >>> + die(_("--no-autostash option is only valid with --rebase.")); >>> + else if (opt_autostash == 1) >> >> The else is not needed since the other branch dies. > > I'm bit confused here. Which "else" you are talking about. The last "else" keyword. Not the "else" branch. It would just work like this, and be a bit more pleasing to my eyes: if (...) die(...); if (...) die(...); -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html