Re: [PATCH v7 30/33] refs: break out resolve_ref_unsafe_submodule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-03-01 at 17:21 +0000, Ramsay Jones wrote:
> 
> On 01/03/16 00:53, David Turner wrote:
> > It will soon be useful for resolve_ref_unsafe to support
> > submodules.
> > But since it is called from so many places, changing it would have
> > been painful.  Fortunately, it's just a thin wrapper around (the
> > former) resolve_ref_1.  So now resolve_ref_1 becomes
> > resolve_ref_unsafe_submodule, and it passes its submodule argument
> > through to read_raw_ref.
> > 
> > The files backend doesn't need this functionality, but it doesn't
> > hurt.
> > 
> > Signed-off-by: David Turner <dturner@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> > ---
> >  refs.c               | 41 +++++++++++++++++++++++++---------------
> > -
> >  refs/files-backend.c |  8 ++++++--
> >  refs/refs-internal.h | 19 ++++++++++++++++---
> >  3 files changed, 47 insertions(+), 21 deletions(-)
> > 
> > diff --git a/refs.c b/refs.c
> > index 5fe0bac..d1cf707 100644
> > --- a/refs.c
> > +++ b/refs.c
> > @@ -60,6 +60,9 @@ void register_ref_storage_backends(void)
> >  	 * entries below when you add a new backend.
> >  	 */
> >  	register_ref_storage_backend(&refs_be_files);
> > +#ifdef USE_LIBLMDB
> > +	register_ref_storage_backend(&refs_be_lmdb);
> > +#endif
> 
> Again, just skimming patches, ...
> 
> The lmdb refs backend (hence refs_be_lmdb) is not introduced until
> the next patch [31/33], right?

Yep.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]