On Mon, Feb 29, 2016 at 2:58 PM, Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote: > > +test_expect_success 'cmdline credential config passes into submodules' ' > + git init super && > + set_askpass user@host pass@host && I wonder why we use pass@host as a password, it seems confusing to me. p@ssword would have worked if we wanted to test a password containing an @, pass@host doesn't quite fit my mental model of how passwords work. No need to change anything, better be consistent with the rest of the tests. > + ( > + cd super && > + git submodule add "$HTTPD_URL/auth/dumb/repo.git" sub && > + git commit -m "add submodule" > + ) && > + set_askpass wrong pass@host && > + test_must_fail git clone --recursive super super-clone && > + rm -rf super-clone && > + set_askpass wrong pass@host && Why set set_askpass a second time here? > + git -c "credential.$HTTP_URL.username=user@host" \ > + clone --recursive super super-clone && > + expect_askpass pass user@host > +' Thanks for this test! Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html